Skip to content

Fixes to be able to compile MPICH testsuite #13192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

hppritcha
Copy link
Member

In going down the rabbit hole of trying to get the MPICH testsuite to compile/link using Open MPI main, a number of problems were uncovered. These included:

  • a missing MPI_T parameter concerning sessions
  • problems with the way the new use mpi_f08 bindings were being generated for profiling interfaces
  • fix problems with the MPI_(UN)PACK_EXTERNAL argument definitions

This PR addresses these problems.

devreal
devreal previously approved these changes Apr 14, 2025
Copy link
Contributor

@devreal devreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me but I don't know much about the generator.

In going down the rabbit hole of trying to get the MPICH testsuite to
compile/link using Open MPI main, a number of problems were uncovered.
These included:
- a missing MPI_T parameter concerning sessions
- problems with the way the new use mpi_f08 bindings were being generated for profiling interfaces
- fix problems with the MPI_(UN)PACK_EXTERNAL argument definitions

This PR addresses these problems.

Signed-off-by: Howard Pritchard <[email protected]>
@hppritcha
Copy link
Member Author

@devreal could you recheck? only thing that's changed is in the mpi-f08-rename.h file

@hppritcha hppritcha merged commit 08ac1be into open-mpi:main Apr 16, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants